Kewen:

On 7/25/24 1:24 AM, Kewen.Lin wrote:

<snip>

optimization the number of assembly generated for the two methods are
similar.  With -O3 optimization, the assembly generated for the two
approaches is identical for the 2DF and 2DI types.  The assembly for
the C-code version of the 1Ti requres one less assembly instruction.
Nit: s/requres/requires/
Fixed<snip>
    fprintf (header_file, "\n");
-  fprintf (header_file,
-       "#define bif_is_set(x)\t\t((x).bifattrs & bif_set_bit)\n");
    fprintf (header_file,
         "#define bif_is_extract(x)\t((x).bifattrs & bif_extract_bit)\n");
    fprintf (header_file,
@@ -2497,10 +2491,9 @@ write_bif_static_init (void)
        fprintf (init_file, "      /* nargs */\t%d,\n",
             bifp->proto.nargs);
        fprintf (init_file, "      /* bifattrs */\t0");
-      if (bifp->attrs.isset)
-    fprintf (init_file, " | bif_set_bit");
        if (bifp->attrs.isextract)
      fprintf (init_file, " | bif_extract_bit");
+
Nit: unnecessary empty line.

Fixed

                                 Carl

Reply via email to