Kewen:
On 7/25/24 1:21 AM, Kewen.Lin wrote:
The patch, first patch in this series, to remove the __builtin_vec_set_v1ti,
__builtin_vec_set_v2df, __builtin_vec_set_v2di was previously posted. The
feedback on the patch was that we could also remove set bif attribute. Removal
of the set bif attribute requires also removing the __builtin_vsx_set_1ti,
__builtin_vsx_set_2df, __builtin_vsx_set_2di built-ins. The second patch
removes the vsx set built-ins and the now no longer used set built-in attribute
and associated code.
The patches have been tested on a Power 10 LE system with no regressions.
It would be good to test this on BE as well (both 64-bit and 32-bit).
Yes. I updated my scripts to test the vec_set and vsx_set code
generations with -m32. The code generation for the various test case
with -m32 and -m64. The code generation for -m32 versus -m64 is
slightly different as expected. When comparing the results with and
without the patch for -m32 the generated assembly is again the same or
better for the C code versus the built-ins. So, no surprises with any
of the testing with -m32. It is consistent with the results for the
-m64 testing.
Carl
