On Tue, 16 Jul 2024 at 17:05, Jason Merrill <ja...@redhat.com> wrote:
> The change looks good, just a couple of whitespace tweaks needed. But
> what happened to the testcase?
I was unable to design any testcase that differs by applying this
patch, due to the proper handling of hash collisions
(hash-table.h:1059).
> > --- a/gcc/cp/pt.cc
> > +++ b/gcc/cp/pt.cc
> > @@ -4525,7 +4525,12 @@ struct ctp_hasher : ggc_ptr_hash<tree_node>
> > val = iterative_hash_object (TEMPLATE_TYPE_LEVEL (t), val);
> > val = iterative_hash_object (TEMPLATE_TYPE_IDX (t), val);
> > if (TREE_CODE (t) == TEMPLATE_TYPE_PARM)
> > - val = iterative_hash_template_arg (CLASS_PLACEHOLDER_TEMPLATE (t),
> > val);
> > + {
> > + val
>
> Extra space at end of line.
>
> > + = iterative_hash_template_arg (CLASS_PLACEHOLDER_TEMPLATE (t), val);
> > + if (tree c = NON_ERROR (PLACEHOLDER_TYPE_CONSTRAINTS (t)))
> > + val = iterative_hash_placeholder_constraint(c, val);
>
> Missing space before paren.
My apologies. Thank you for pointing those out.
