Thanks Jeff. > Do we really need stdio.h? If not, let's avoid this hunk. No, should be debug code, will remove it and commit the series.
Pan -----Original Message----- From: Jeff Law <jeffreya...@gmail.com> Sent: Tuesday, July 9, 2024 1:34 AM To: Li, Pan2 <pan2...@intel.com>; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; rdapp....@gmail.com Subject: Re: [PATCH v1 1/2] RISC-V: Add testcases for unsigned vector .SAT_ADD IMM form 1 On 7/8/24 8:15 AM, pan2...@intel.com wrote: > From: Pan Li <pan2...@intel.com> > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/autovec/binop/vec_sat_arith.h: Add help > test macro. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_data.h: New test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-1.c: New test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-2.c: New test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-3.c: New test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-4.c: New test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-run-1.c: New > test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-run-2.c: New > test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-run-3.c: New > test. > * gcc.target/riscv/rvv/autovec/binop/vec_sat_u_add_imm-run-4.c: New > test. Both patches in this series is OK. One minor question/nit below. > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/binop/vec_sat_arith.h > b/gcc/testsuite/gcc.target/riscv/rvv/autovec/binop/vec_sat_arith.h > index a3116033fb3..0e5e07a38b6 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/binop/vec_sat_arith.h > +++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/binop/vec_sat_arith.h > @@ -3,6 +3,15 @@ > > #include <stdint-gcc.h> > #include <stdbool.h> > +#include <stdio.h> Do we really need stdio.h? If not, let's avoid this hunk. jeff
