Hi Alexandre,

> On Jun 27, 2024, Hongtao Liu <crazy...@gmail.com> wrote:
>
>> LGTM, thanks.
>
>> On Thu, Jun 13, 2024 at 3:32 PM Alexandre Oliva <ol...@adacore.com> wrote:
>
>>> for  gcc/ChangeLog
>>> 
>>> PR target/113719
>>> * config/i386/i386-options.cc
>>> (ix86_override_options_after_change_1): Add opts and opts_set
>>> parms, operate on them, after factoring out of...
>>> (ix86_override_options_after_change): ... this.  Restore calls
>>> of ix86_default_align and ix86_recompute_optlev_based_flags.
>>> (ix86_option_override_internal): Call the factored-out bits.
>
> Thanks, I've finally put it in.

unfortunately this patch caused two regressions on Solaris/x86:

FAIL: gcc.dg/ipa/iinline-attr.c scan-ipa-dump inline "hooray[^\\\\n]*inline 
copy in test"

both 32 and 64-bit.  Solaris/x86 does default to -fno-omit-frame-pointer.

This failure was fixed before by

commit 499d00127d39ba894b0f7216d73660b380bdc325
Author: Hongyu Wang <hongyu.w...@intel.com>
Date:   Wed May 15 11:24:34 2024 +0800

    i386: Fix ix86_option override after change [PR 113719]

Obviously the two patches interact badly.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to