On Mon, Mar 18, 2024 at 3:59 PM Fangrui Song <mask...@google.com> wrote: > > On Mon, Mar 18, 2024 at 3:10 PM Evgeny Karpov > <evgeny.kar...@microsoft.com> wrote: > > > > > > Monday, March 18, 2024 2:34 PM > > Christophe Lyon wrote: > > > > > I had a look at the v2 series, and besides a minor comment patch #8, ISTM > > > than > > > all the comments your received about v1 have been addressed, indeed. > > > > > > > While unit testing for the x86_64-w64-mingw32 target is still in > > > > progress, the first 4 patches do not obviously change other targets, > > > > including aarch64-linux-gnu. > > > > Could they be merged once stage 1 starts, or could it be done even > > > > now? > > > > > > What would be the benefit of committing only the first 4 patches? > > > (whether now or when stage 1 reopens) > > > > > > Thanks, > > > > > > Christophe > > > > Work on obtaining regression test results for x86_x64-w64-mingw32 was still > > in progress at that moment. > > The first 4 patches do not obviously change other targets, so it was safe > > to merge them. > > Now, based on the regression test results > > https://gcc.gnu.org/pipermail/gcc-patches/2024-March/647967.html, > > it appears safe to merge the entire series. > > > > Regards, > > Evgeny > > LLVM has had an aarch64 mingw ABI support for a long time. Does this > patch series introduce a different ABI? > If yes, do you have a summary? > > Does the patch need any adaptation on the LLVM side, or should a > different target triple be picked? > I have always been wondering what "32" in "x86_x64-w64-mingw32" means.
It was always mingw32, it comes from win32 API interface which dates to when windows also a 16bit API too. The API has always been named win32 and Microsoft didn't rename it to win64 though. Thanks, Andrew Pinski > > https://github.com/llvm/llvm-project/pull/78908 even introduced the > first use of the triple "arm64ec-w64-mingw32" into llvm-project. > > > -- > 宋方睿
