Hi FX, > On 17 Nov 2023, at 14:20, FX Coudert <fxcoud...@gmail.com> wrote: > >>> I have done a full rebuild, and having looked more at the structure of >>> libtool.m4 I am now convinced that having that line outside of the scope of >>> _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a copy-pasto or >>> leftover from earlier code).
The latter; my original patch to do this had all the work inside libtool.m4 - but that proved to be unwieldy in practice, so the eventual patch split the ENABLE_DARWIN_AT_RPATH AM_CONDITIONAL out and applies it (after libtool is initiallised) in configure.ac cases that need it. It seems I failed to remove all the old code in that change :(. >>> Having rebuilt everything, it only manifests itself in >>> fixincludes/ChangeLog. Iain is traveling right now, but when he is back I >>> would like to submit this patch if he agrees with the above. It was >>> regtested on x86_64-apple-darwin21. I have also regtested on i686, x86_64, aarch64 Darwin, x86_64 and aarch64 Linux. > > With the correct patch attached. I believe this can be applied as a partial reversion of a previously approved patch, thanks Iain > > <0001-Build-fix-error-in-fixinclude-configure.patch>
