Hi FX! On 2023-11-17T12:56:13+0100, FX Coudert <fxcoud...@gmail.com> wrote: >> If I remove the line from libtool.m4 (innocent smile) I see that >> fixincludes/configure is better, and it does not appear to change the >> regenerated files in other directories (I didn’t do a build yet, just tried >> to regenerate with some manual autoconf invocations). > > I have done a full rebuild, and having looked more at the structure of > libtool.m4 I am now convinced that having that line outside of the scope of > _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a copy-pasto or leftover > from earlier code).
Sounds reasonable to me, from the textual description. > Having rebuilt everything, it only manifests itself in fixincludes/ChangeLog. > Iain is traveling right now, but when he is back I would like to submit this > patch if he agrees with the above. It was regtested on x86_64-apple-darwin21. > > Thomas, can you confirm that it also fixes things for you? Although I don’t > see why it wouldn’t. > Subject: [PATCH] libsanitizer: fix build on darwin EATTACHEDWRONGPATCH? ;-) Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955