On Thu, May 17, 2012 at 12:19 PM, Chung-Lin Tang <clt...@codesourcery.com> wrote: > On 2012/5/17 01:55 AM, Manuel López-Ibáñez wrote: >>> I'm guessing these changes are the cause of a full C bootstrap >>> > (--disable-build-poststage1-with-cxx) failure I'm seeing on trunk. The >>> > *_handle_option_auto function prototypes are not seen in options.c, and >>> > -Werror -Wmissing-prototypes are in effect (oddly, such strict checking >>> > is not enforced in the default post-stage1 C++ bootstrap) >> Yep, We should add -Wmissing-declarations to the post-stage1 flags, >> which also exists in C. Could you also add that to your patch? >> > > I'm a little unsure of how -Wmissing-declarations vs > -Wmissing-prototypes behave for C? Anyways here's a patch to add > -Wmissing-declarations for C++, keeping C as is.
What is the purpose of -Wmissing-declarations for C++? > > Joseph, how does this look? It makes the default post-stage1 C++ > bootstrap fail similarly without the other options.c Makefile change, so > I guess it works as intended. > > I'll commit both changes together once approved. > > Thanks, > Chung-Lin > > 2012-05-18 Chung-Lin Tang <clt...@codesourcery.com> > > * configure.ac: Check for -Wmissing-declarations for C++. > * configure: Regenerate. > * Makefile.in (CXX_LOOSE_WARN): Set to @cxx_loose_warn@. > (GCC_WARN_CXXFLAGS): Add $(CXX_LOOSE_WARN).
