On 6/14/23 06:05, Robin Dapp via Gcc-patches wrote:
Oh. I see Robin's email is also wrong. CC Robin too for you....
It still arrived via the mailing list ;)
Good to see a Fix patch of the ICE before Vector ABI patch.
Let's wait for more comments.
LGTM, this way I don't even need to rewrite my tests.
I think Palmer wanted to include a pointer to the psabi MR, so we should
probably include that in a comment. So OK with that in a comment.
I think there was talk of having this all be hidden behind a flag, but
given it's an ICE on vector types, I don't mind just defining something
for now to fix the ICE and give psabi time to finalize that spec.
This was also a good reminder that the vector work can't really be
complete until we have the psabi updates in place and implemented. The
efforts can obviously continue in parallel, but it's a dependency worth
noting in the RISE context.
Jeff