I think it's ok to add it to specific cases and will not affect other cases. There's not so many cases. And we can revert it after the finalization.
> -----Original Message----- > From: Kito Cheng <kito.ch...@sifive.com> > Sent: Monday, June 12, 2023 10:53 PM > To: Jeff Law <jeffreya...@gmail.com> > Cc: Wang, Yanzhang <yanzhang.w...@intel.com>; gcc-patches@gcc.gnu.org; > juzhe.zh...@rivai.ai; Li, Pan2 <pan2...@intel.com> > Subject: Re: [PATCH v5] RISC-V: Add vector psabi checking. > > Hmmm, yeah, I think let's add it case by case...I assume we should get it > rid before GCC 14, it is mostly used for the transition period before we > settle down the ABI and for GCC 13. > > On Mon, Jun 12, 2023 at 10:34 PM Jeff Law <jeffreya...@gmail.com> wrote: > > > > > > > > On 6/12/23 07:36, Wang, Yanzhang via Gcc-patches wrote: > > > I found that add the -Wno-psabi to CFLAGS will be overrode by > > > dg-options. It seems we can only add this option to the third arg of > > > dg-runtest. Attach the dg-runtest comments, > > I think we default to -Wno-psabi to avoid triggering diagnostics in > > the common case where we aren't concerned about such issues. So not a > > surprise that we'll need to work a bit harder to get it added when we > > do want to check for psabi issues. > > > > jeff
