It's the same behavior. Because the DEFAULT_CFLAGS will be copied to CFLAGS and then passed as the DEFAULT_EXTRA_OPTIONS to dg-runtest.
> -----Original Message----- > From: Kito Cheng <kito.ch...@gmail.com> > Sent: Monday, June 12, 2023 10:08 PM > To: Wang, Yanzhang <yanzhang.w...@intel.com> > Cc: Kito Cheng <kito.ch...@sifive.com>; gcc-patches@gcc.gnu.org; > juzhe.zh...@rivai.ai; Li, Pan2 <pan2...@intel.com> > Subject: Re: [PATCH v5] RISC-V: Add vector psabi checking. > > How about appending to DEFAULT_CFLAGS? > > On Mon, Jun 12, 2023 at 9:38 PM Wang, Yanzhang via Gcc-patches <gcc- > patc...@gcc.gnu.org> wrote: > > > > I found that add the -Wno-psabi to CFLAGS will be overrode by > > dg-options. It seems we can only add this option to the third arg of > > dg-runtest. Attach the dg-runtest comments, > > > > # dg-runtest -- simple main loop useful to most testsuites # # OPTIONS > > is a set of options to always pass. > > # DEFAULT_EXTRA_OPTIONS is a set of options to pass if the testcase # > > doesn't specify any (with dg-option). > > > > > -----Original Message----- > > > From: Kito Cheng <kito.ch...@sifive.com> > > > Sent: Monday, June 12, 2023 8:43 PM > > > To: Wang, Yanzhang <yanzhang.w...@intel.com> > > > Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; Li, Pan2 > > > <pan2...@intel.com> > > > Subject: Re: [PATCH v5] RISC-V: Add vector psabi checking. > > > > > > Hi Yan-Zhang: > > > > > > OK with one minor, go ahead IF the regression is clean. > > > > > > Hi Pan: > > > > > > Could you help to verify this patch and commit if the regression is > clean? > > > > > > thanks :) > > > > > > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > > b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > > > index 5e69235a268..ad79d0e9a8d 100644 > > > > --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > > > +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp > > > > @@ -43,7 +43,7 @@ dg-init > > > > # Main loop. > > > > set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3" > > > > > > Add -Wno-psabi here rather than below, and also add it for > > > g++.target/riscv/rvv/rvv.exp > > > > > > > dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] > \ > > > > - "" $CFLAGS > > > > + "-Wno-psabi" $CFLAGS > > > > gcc-dg-runtest [lsort [glob -nocomplain > > > > $srcdir/$subdir/vsetvl/*.\[cS\]]] > > > \ > > > > "" $CFLAGS > > > > dg-runtest [lsort [glob -nocomplain > > > > $srcdir/$subdir/autovec/*.\[cS\]]] \
