On 7/31/2022 6:44 AM, Lewis Hyatt wrote:
On Sat, Jul 30, 2022 at 10:43 PM Jeff Law <jeffreya...@gmail.com> wrote:
There was a request to backport this
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97498#c7) since it is
relevant to this one:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106267. Is that OK as
well for any of the current release branches please? It will work fine
as far back as 10. Thanks...
Generally we try to focus mostly on codegen issues and regressions on
the release branches, but it's not a strict rule. Given this has been
on the trunk for nearly a couple weeks without issues, feel free to go
ahead and backport per Martin's request.
jeff
Thank you, I'll do that. One question, does a backport need to be an
exact cherry-pick, or is it OK if I need to tweak a few things as
well? I wasn't sure if I need to re-post the patch here in that case.
The patch itself applies to gcc 12 branch fine, however I think I need
a couple small changes to the testsuite parts. Thanks...
I personally prefer cherry-pick when we can, but as you note, sometimes
minor twiddling is necessary, particularly as you go to older and older
branches. If you need to make minor changes, go ahead. Consider the
patch pre-approved with any minor changes you need to make to work with
the branch and just post the patch with a note that it was installed as
pre-approved.
Jeff
