Hi Kito, > I am convinced that is OK for now, I agree modeling fflags would be a > rabbit hole, I tried to build a full GNU toolchain with my quick patch > and saw many ICE during build libraries, that definitely should be a > long-term optimization project. > > Although I'm thinking if we should default -fno-trapping-math for > RISC-V, because RISC-V didn't trap for any floating point operations, > however I think that would be another topic.
No need to do anything for RISC-V I believe, as Richard has mentioned that's been his plan for GCC 13 compiler-wide; see the discussion here: <https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598589.html> for further details. > so you got my LGTM :) I have applied this change now then, thank you for your review. Maciej