On Tue, 2022-07-12 at 06:42 +0000, Dimitrije Milosevic wrote:
> Hi Hans-Peter,
> You're right, this is not ok for the O32 ABI. Your change however, broke the 
> functionality
> for the N32 ABI. AFAIK, the changes like this should go through LLVM first 
> (yours didn't),
> so I will send out a review, covering both 32 ABIs, meaning that both O32 and 
> N32 ABIs 
> will be working properly. As for this change, I'm not sure what should be 
> done? 
> Should this be committed now, while the LLVM change is cherry-picked once 
> it's committed.

I think just get it into LLVM first, then we sync with LLVM.

It seems on o32 sizeof(struct stat) is 144, n32 -> 160, n64 -> 216
(tested on gcc23.fsffrance.org).  "Luckily" we don't support other
strange things like "o64".

Reply via email to