On Fri, 2022-07-08 at 21:42 -0400, Hans-Peter Nilsson wrote: > On Fri, 1 Jul 2022, Dimitrije Milosevic wrote: > > > Fix kernel_stat structure size for non-Android 32-bit Mips. > > LLVM currently has this value for the kernel_stat structure size, > > as per compiler-rt/lib/sanitizer- > > common/sanitizer_platform_limits_posix.h. > > This also resolves one of the build issues for non-Android 32-bit > > Mips. > > I insist that PR105614 comment #7 is the way to go, i.e. fix > the merge error, avoiding the faulty include that it > reintroduced. Was this tested on O32?
I'm pretty sure it is *not* the way to go. Sanitizer does not really intercept system call. It intercepts libc stat() or lstat() etc. calls. So you need to keep struct_kernel_stat_sz same as the size of struct stat in libc, i. e. "the size of buffer which *libc* stat()-like functions writing into". The "kernel_" in the name is just misleading. And, if you still think it should be the way to go, let's submit the change to LLVM and get it reviewed properly. -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University
