On Mon, 2022-07-04 at 21:21 -0700, Fangrui Song wrote: > > > > > > > FAIL: c-c++-common/tsan/tls_race.c -O0 output pattern test > > > > Output was: > > > > ThreadSanitizer: CHECK failed: tsan_platform_linux.cpp:452 > > > > "((thr_end)) <= ((tls_addr + tls_size))" (0xffec35f8c0, > > > > 0xffec35f784) (tid=748216) > > > > #0 __tsan::CheckUnwind() > > > > ../../../../gcc/libsanitizer/tsan/tsan_rtl.cpp:627 > > > > (libtsan.so.2+0xa30ec) > > > > #1 __sanitizer::CheckFailed(char const*, int, char const*, > > > > unsigned long long, unsigned long long) > > > > ../../../../gcc/libsanitizer/sanitizer_common/sanitizer_termination. > > > > cpp:86 (libtsan.so.2+0xeb8cc) > > > > #2 __tsan::ImitateTlsWrite(__tsan::ThreadState*, unsigned long, > > > > unsigned long) > > > > ../../../../gcc/libsanitizer/tsan/tsan_platform_linux.cpp:452 > > > > (libtsan.so.2+0xa0cac) > > > > #3 __tsan::ThreadStart(__tsan::ThreadState*, unsigned int, > > > > unsigned long long, __sanitizer::ThreadType) > > > > ../../../../gcc/libsanitizer/tsan/tsan_rtl_thread.cpp:197 > > > > (libtsan.so.2+0xc0e88) > > > > #4 __tsan_thread_start_func > > > > ../../../../gcc/libsanitizer/tsan/tsan_interceptors_posix.cpp:1009 > > > > (libtsan.so.2+0x3e5dc) > > > > #5 start_thread /sources/glibc-2.35/nptl/pthread_create.c:442 > > > > (libc.so.6+0xc75f4) > > > > > > > > I've tried to diagnose the root cause but failed. > > > > > > Hi Xi, thanks for looking into this. I've tried running the testsuite > > > on a cross-toolchain (as I do not currently have access to a physical > > > machine) > > > for a MIPS64R6 and the test passes successfully. Could you please > > > verify that the test fails solely based on this change?
I've got a clue about why this happens. See https://reviews.llvm.org/D129112. It depends on how the dynamic linker arranges TLS blocks so different version of Glibc may produce different results. -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University