On Mon, 2022-07-04 at 21:21 -0700, Fangrui Song wrote: > Clang considers that asan/msan/tsan/dataflow/etc enables > -fasynchronous-unwind-tables by default so I assume this GCC change is > fine.
I agree it's fine, but the problem is TSAN is currently "unsupported" within GCC (i. e. when you build gcc libtsan is not built). So it does not make any benefit to commit this change before making TSAN supported on GCC side. Dimitrije told me TSAN should be supported on 64-bit MIPS, but I can't make it work fine with GCC. I'll need some time to debug... > With https://reviews.llvm.org/D102046 ("[sanitizer] Fall back to fast > unwinder"), compiler-rt may fall back to the frame pointer based > unwinder. There is not strong need to have the default > -fasynchronous-unwind-tables or -funwind-tables behavior. > However, most targets still default to omit frame pointer, so it's a > bit unfortunately that we need to enable unwind tables to get good > diagnostics. -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University
