On Mon, May 16, 2022 at 11:42:03AM +0200, Tobias Burnus wrote:
> small update (interdiff): s/s/S/ for consistency, missed one GCC 13 commit,
> and
> improved wording of the enter/exit change. (New wording better captures the
> effect; I was thinking too much of the changed spec wording not of the
> effective
> result.)
> Plus added some cross-ref hyperlinks to make finding the documentation easier:
>
> --- a/htdocs/projects/gomp/openmp-status.html
> +++ b/htdocs/projects/gomp/openmp-status.html
> @@ -25,0 +26 @@
> + <li><a href="index.html">GOMP project page</a></li>
> @@ -61 +61 @@
> -<tr><td><code>hint</code> clause on the <code>atomic</code>
> construct</td><td>GCC 9</td><td>stub only</td></tr>
> +<tr><td><code>hint</code> clause on the <code>atomic</code>
> construct</td><td>GCC 9</td><td>Stub only</td></tr>
> @@ -141,0 +142 @@
> +<tr><td><code>omp_get_mapped_ptr</code> runtime
> routine</td><td>GCC 13</td><td></td></tr>
> @@ -159 +159,0 @@>
> -<tr><td><code>omp_get_mapped_ptr</code> runtime
> routine</td><td>N</td><td></td></tr>
> @@ -195 +195 @@
> -<tr><td>Extended map-type handling of <code>target enter/exit
> data</code></td><td>N</td><td></td></tr>
> +<tr><td>Default map type for <code>map</code> clause in <code>target
> enter/exit data</code></td><td>N</td><td></td></tr>
>
> --- a/htdocs/projects/index.html
> +++ b/htdocs/projects/index.html
> @@ -32,0 +33 @@ help develop GCC:</p>
> +<li><a href="gomp/openmp-status.html">Implementing missing OpenMP
> features.</a></li>
>
>
> I will incorporate the 5.2 wording change in my libgomp.texi patch.
> (I think the s/stub/Stub/ change is already there and I know the
> N→Y change is in the .texi.)
Thanks for working on this.
Please incorporate Gerald's comments and my comments about the
libgomp.texi 5.2 support patch.
> +<p>Features added by OpenMP version</p>
> +<ul>
> + <li><a href="#omp4.5">OpenMP 4.5</a></li>
> + <li><a href="#omp5.0">OpenMP 5.0</a></li>
> + <li><a href="#omp5.1">OpenMP 5.1</a></li>
> + <li><a href="#omp5.2">OpenMP 5.2</a></li>
> +</ul>
I think we should have also 2.5, 3.0, 3.1 and 4.0 entries in the above list,
with similar style as the OpenMP 4.5 entry.
Details can be copied from the gomp/index.html page, so
2.5 supported since GCC 4.2,
3.0 supported since GCC 4.4,
3.1 supported since GCC 4.7,
4.0 supported for C/C++ since GCC 4.9 and for Fortran since GCC 4.9.1
Though, maybe a table form for the 2.5-4.5 versions would be more consistent
with the rest, and just use OpenMP x.y C/C++/Fortran support
or OpenMP x.y C/C++ support or OpenMP x.y Fortran support as name,
for the partial/full with 2 rows like requires directive with GCC 7 row
and partial in comment and GCC 11 witout a comment or with fully supported
comment? Perhaps for those tables just leave the first column header blank
instead of "Feature".
> +<tr><td>Map-order clarifications</td><td>GCC?</td><td></td></tr>
This entry I gave up on, it isn't exactly clear to me what that
bullet is about and once we figure that out, we need to do some archeology
on whether we support it at all and if yes, since which commit and thus
since which GCC version.
Otherwise LGTM.
Jakub
