On Thu, Apr 07, 2022 at 08:50:53AM -0500, will schmidt wrote: > On Thu, 2022-04-07 at 06:00 -0500, Segher Boessenkool wrote: > > On Thu, Apr 07, 2022 at 12:29:45AM -0400, Michael Meissner wrote: > > > In PR target/104253, it was pointed out the that test case added as part > > > of fixing the PR does not work on VxWorks because float128 is not > > > supported on that system. I have modified the three tests for float128 so > > > that they are manually excluded on VxWorks systems. In looking at the > > > code, I also added checks in check_effective_target_ppc_ieee128_ok to > > > disable the systems that will never support VSX instructions which are > > > required for float128 support (eabi, eabispe, darwin). > > > > It's just one extra to the big list here, but, why do we need all these > > manual exclusions anyway? What is broken about the test itself? > > >From the PR, it looks like this test noted an error, not actually a > failure. > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104253#c17 > > cc1: warning: The '-mfloat128' option may not be fully supported
Aha, thanks for checking. If that is what causes the error, the test in target-supports needs robustifying. > > It would be so much more useful if the tests would help us, instead of > > producing a lot of extra busy-work. (^^^ to help improve this) Segher
