On Thu, 2022-04-07 at 06:00 -0500, Segher Boessenkool wrote: > On Thu, Apr 07, 2022 at 12:29:45AM -0400, Michael Meissner wrote: > > In PR target/104253, it was pointed out the that test case added as part > > of fixing the PR does not work on VxWorks because float128 is not > > supported on that system. I have modified the three tests for float128 so > > that they are manually excluded on VxWorks systems. In looking at the > > code, I also added checks in check_effective_target_ppc_ieee128_ok to > > disable the systems that will never support VSX instructions which are > > required for float128 support (eabi, eabispe, darwin). > > It's just one extra to the big list here, but, why do we need all these > manual exclusions anyway? What is broken about the test itself?
>From the PR, it looks like this test noted an error, not actually a failure. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104253#c17 cc1: warning: The '-mfloat128' option may not be fully supported which comes out of gcc/config/rs6000/rs6000.cc rs6000_option_override_internal() via /* IEEE 128-bit floating point requires VSX support. */ if (TARGET_FLOAT128_KEYWORD) { if (!TARGET_VSX) { <snip> } else if (!TARGET_FLOAT128_TYPE) { TARGET_FLOAT128_TYPE = 1; warning (0, "The %<-mfloat128%> option may not be fully supported"); } } > > It would be so much more useful if the tests would help us, instead of > producing a lot of extra busy-work. > > > Segher
