On Thu, Feb 03, 2022 at 12:59:43PM +0100, David Seifert wrote: > I have an FSF copyright assignment, is there anything you need me to do > to this end?
Ok. > > > --- a/libsanitizer/configure.ac > > > +++ b/libsanitizer/configure.ac > > > @@ -400,6 +400,15 @@ fi > > > AC_SUBST([TSAN_TARGET_DEPENDENT_OBJECTS]) > > > AC_SUBST([SANITIZER_COMMON_TARGET_DEPENDENT_OBJECTS]) > > > > > > +AC_ARG_ENABLE([werror], [ > > > + AS_HELP_STRING([--disable-werror], [disable building with - > > > Werror])]) > > > + > > > +WARN_FLAGS="-Wextra -Wall -Wwrite-strings -Wmissing-format- > > > attribute -Wcast-qual" > > > > This should be using > > ACX_PROG_CC_WARNING_OPTS([-Wextra -Wall -Wwrite-strings \ > > -Wmissing-format-attribute -Wcast-qual], > > [WARN_FLAGS]) > > instead. Then just this change and a note where and how it has been tested, I can commit it afterwards for you. Jakub