On Thu, Feb 03, 2022 at 12:30:11PM +0100, David Seifert wrote: > * `-Werror` can cause issues when a more recent version of GCC compiles > an older version: > - https://bugs.gentoo.org/229059 > - https://bugs.gentoo.org/475350 > - https://bugs.gentoo.org/667104 > > libatomic/ChangeLog: > > * libatomic/configure.ac: Support --disable-werror. > * libatomic/configure: Regenerate. > > libbacktrace/ChangeLog: > > * libbacktrace/configure.ac: Support --disable-werror. > * libbacktrace/configure: Regenerate. > > libgo/ChangeLog: > > * libgo/configure.ac: Support --disable-werror. > * libgo/configure: Regenerate. > > libgomp/ChangeLog: > > * libgomp/configure.ac: Support --disable-werror. > * libgomp/configure: Regenerate. > > libitm/ChangeLog: > > * libitm/configure.ac: Support --disable-werror. > * libitm/configure: Regenerate. > > libsanitizer/ChangeLog: > > * libsanitizer/configure.ac: Support --disable-werror. > * libsanitizer/libbacktrace/Makefile.am (WARN_FLAGS): Remove.
As Jonathan wrote, if you don't have a copyright assignment on file, we need either that copyright assignment or the patch needs to be submitted according to https://gcc.gnu.org/dco.html which is expressed by Signed-off-by line in the mail and commit message. > --- a/libsanitizer/configure.ac > +++ b/libsanitizer/configure.ac > @@ -400,6 +400,15 @@ fi > AC_SUBST([TSAN_TARGET_DEPENDENT_OBJECTS]) > AC_SUBST([SANITIZER_COMMON_TARGET_DEPENDENT_OBJECTS]) > > +AC_ARG_ENABLE([werror], [ > + AS_HELP_STRING([--disable-werror], [disable building with -Werror])]) > + > +WARN_FLAGS="-Wextra -Wall -Wwrite-strings -Wmissing-format-attribute > -Wcast-qual" This should be using ACX_PROG_CC_WARNING_OPTS([-Wextra -Wall -Wwrite-strings \ -Wmissing-format-attribute -Wcast-qual], [WARN_FLAGS]) instead. Otherwise LGTM. Jakub
