Hi!

On Tue, Nov 16, 2021 at 11:06:55AM -0600, Bill Schmidt via Gcc-patches wrote:
> gcc/
>       * config/rs6000/rs6000-builtin-new.def: Add power6-64 stanza.
>       Move CMPB to power6-64 stanza.

Don't break lines early please.

>       * config/rs6000/rs6000-call.c (rs6000_invalid_new_builtin): Handle
>       ENB_P6_64 case.
>       (rs6000_new_builtin_is_supported): Likewise.
>       (rs6000_expand_new_builtin): Likewise.
>       (rs6000_init_builtins): Likewise.
>       * config/rs6000/rs6000-gen-builtins.c (bif_stanza): Add
>       BSTZ_P6_64.

It's worse here :-(

>       (stanza_map): Add entry mapping power6-64 to BSTZ_P6_64.
>       (enable_string): Add "ENB_P6_64".
>       (write_decls): Add ENB_P6_64 to bif_enable enum.

> @@ -15697,6 +15703,8 @@ rs6000_expand_new_builtin (tree exp, rtx target,
>    if (!(e == ENB_ALWAYS
>       || (e == ENB_P5         && TARGET_POPCNTB)
>       || (e == ENB_P6         && TARGET_CMPB)
> +     || (e == ENB_P6_64      && TARGET_CMPB
> +                             && TARGET_POWERPC64)

This is curious formatting.  And you are introducing tabs halfway a
line; don't do that, use spaces there, this is not a table.

This fits easily on a single line, so just do that?

>       || (e == ENB_ALTIVEC    && TARGET_ALTIVEC)
>       || (e == ENB_CELL       && TARGET_ALTIVEC
>                               && rs6000_cpu == PROCESSOR_CELL)

(I do realise this entry isn't correct formatting either).

Okay for trunk with those things fixed.  Thanks!


Segher

Reply via email to