Hi! On Thu, Sep 30, 2021 at 11:06:50AM +0800, Kewen.Lin wrote:
[ huge snip ] > Based on the understanding and testing, I think it's safe to adopt this patch. > Do both Peter and you agree the rs6000_expand_builtin will catch the invalid > built-in? > Is there some special case which probably escapes out? The function rs6000_builtin_decl has a terribly generic name. Where all is it called from? Do all such places allow the change in semantics? Do any comments or other documentation need to change? Is the function name still good? > By the way, I tested the bif rewriting patch series V5, it couldn't make the > original > case in PR (S5) pass, I may miss something or the used series isn't > up-to-date. Could > you help to have a try? I agree with Peter, if the rewriting can fix this > issue, then > we don't need this patch for trunk any more, I'm happy to abandon this. :) (Mail lines are 70 or so chars max, so that they can be quoted a few levels). If we do need a band-aid for 10 and 11 (and we do as far as I can see), I'd like to see one for just MMA there, and let all other badness fade into history. Unless you can convince me (in the patch / commit message) that this is safe :-) Whichever way you choose, it is likely best to do the same on 10 and 11 as on trunk, since it will all be replaced on trunk soon anyway. Segher
