On Wed, Sep 8, 2021 at 5:09 PM Jakub Jelinek <ja...@redhat.com> wrote:
>
> On Wed, Sep 08, 2021 at 10:37:17AM +0800, Hongtao Liu wrote:
> >   Bootstrapped and regtested on x86_64-linux-gnu{-m32,}.
> >   Ok for trunk?
> >
> > libgcc/ChangeLog:
> >
> >         * config/i386/t-softfp: Compile __{mul,div}hc3 into
> >         libgcc_s.so.1.
>
> I think this is ok, but not really useful until the *.ver change is acked,
> because what this patch alone does is add extra non-exported entrypoints to
> the shared library (aka wasted .text).
I think your patch is ok (with divhc3/mulhc3), we can check in the
respective patches. :)
>
> >  libgcc/config/i386/t-softfp | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/libgcc/config/i386/t-softfp b/libgcc/config/i386/t-softfp
> > index 2363ea17194..7620cc0cec5 100644
> > --- a/libgcc/config/i386/t-softfp
> > +++ b/libgcc/config/i386/t-softfp
> > @@ -2,9 +2,8 @@ LIB2ADD += $(srcdir)/config/i386/sfp-exceptions.c
> >
> >  # Replace _divhc3 and _mulhc3.
> >  libgcc2-hf-functions = _divhc3 _mulhc3
> > -LIB2FUNCS_EXCLUDE += $(libgcc2-hf-functions)
> >  libgcc2-hf-extras = $(addsuffix .c, $(libgcc2-hf-functions))
> > -LIB2ADD_ST += $(addprefix $(srcdir)/config/i386/, $(libgcc2-hf-extras))
> > +LIB2ADD += $(addprefix $(srcdir)/config/i386/, $(libgcc2-hf-extras))
> >
> >  softfp_extensions := hfsf hfdf hftf hfxf sfdf sftf dftf xftf
> >  softfp_truncations := tfhf xfhf dfhf sfhf tfsf dfsf tfdf tfxf
>
>         Jakub
>


-- 
BR,
Hongtao

Reply via email to