On Fri, Sep 03, 2021 at 01:36:36PM +0100, Iain Sandoe wrote:
> oops EWRONGPATCH
>
> diff --git a/libgcc/libgcc-std.ver.in b/libgcc/libgcc-std.ver.in
> index cea33267e53..902a9364850 100644
> --- a/libgcc/libgcc-std.ver.in
> +++ b/libgcc/libgcc-std.ver.in
> @@ -1944,3 +1944,23 @@ GCC_7.0.0 {
> __PFX__divmoddi4
> __PFX__divmodti4
> }
> +
> +%inherit GCC_12.0.0 GCC_7.0.0
> + GCC_12.0.0 {
> + __PFX__divhc3
> + __PFX__mulhc3
> + __PFX__eqhf2
> + __PFX__extendhfdf2
> + __PFX__extendhfsf2
> + __PFX__extendhftf2
> + __PFX__extendhfxf2
> + __PFX__fixhfti
> + __PFX__fixunshfti
> + __PFX__floattihf
> + __PFX__floatuntihf
> + __PFX__nehf2
> + __PFX__truncdfhf2
> + __PFX__truncsfhf2
> + __PFX__trunctfhf2
> + __PFX__truncxfhf2
> +}
>
I don't think this should be done in libgcc/libgcc-std.ver.in,
the addition of those *h[fc]* entrypoints wasn't a generic change,
but change on a particular target, other targets can add those
entrypoints in GCC 15, never etc. And while non-existent symbols
are filtered away by the scripts, if some arch adds them later, they
might show up under the GCC_12.0.0 symver instead of some other.
And e.g. aarch64 already has in config/aarch64/libgcc-softfp.ver
__divhc3
__extendhftf2
__fixhfti
__fixunshfti
__floattihf
__floatuntihf
__mulhc3
__trunctfhf2
under GCC_11.0 symver. IMHO those changes
belong to libgcc/config/i386/*.ver but that means multiple files
need changes.
Jakub
