On Wed, 07 Jul 2021 16:26:25 PDT (-0700), i...@maskray.me wrote:
On 2021-07-02, Kito Cheng wrote:
It was undocument before, but already used in linux kernel, so LLVM
community suggest we should document that, so that make it become
supported/documented/non-internal machine constraints.

gcc/ChangeLog:

        PR target/101275
        * doc/md.text (Machine Constraints): Document the 'S' constraints
        for RISC-V.
---
gcc/doc/md.texi | 3 +++
1 file changed, 3 insertions(+)

diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi
index 00caf3844cc..b776623e8a5 100644
--- a/gcc/doc/md.texi
+++ b/gcc/doc/md.texi
@@ -3536,6 +3536,9 @@ A 5-bit unsigned immediate for CSR access instructions.
@item A
An address that is held in a general-purpose register.

+@item S
+A constant call address.
+
@end table

@item RX---@file{config/rx/constraints.md}
--
2.31.1


Ping on this:)

Thanks, I hadn't had time to look a this but it was on the list.

'S' can be used on either a variable or a function. Does "A constant call 
address." need change?

I think so: this can certainly be used to generate arbitrary constant addresses into assembly, but I don't remember if there was some reason it was listed as only applying to call addresses. It certainly could just be a historical artifact, as those strings tend to bit rot when they're internal, but I wanted to at least take a look.

Also: IIUC we're supposed to remove the @internal when something is documented (though I remember having said that before, so I might be mistaken).

Reply via email to