On Thu, Apr 29, 2021 at 07:23:03PM -0400, Michael Meissner wrote: > On Thu, Apr 29, 2021 at 05:50:03PM -0500, Segher Boessenkool wrote: > > On Thu, Apr 29, 2021 at 05:48:53PM -0400, Michael Meissner wrote: > > > This patch defines the constants needed for libgcc for the PowerPC > > > specific IEEE 128-bit floating point types (KFmode). > > > > It doesn't do that though? > > Yes it does. With this patch and if you use -fbuilding-libgcc, it defines: > > __LIBGCC_KF_MAX__ > __LIBGCC_KF_MIn__ > __LIBGCC_KF_EPSILON__ > > That the new version of _divkc3.c uses.
But you said the *patch* defines the constants. It doesn't. > > > gcc/ > > > 2021-04-29 Michael Meissner <meiss...@linux.ibm.com> > > > > > > PR bootstrap/100327 > > > * config/rs6000/rs6000.c > > > (TARGET_LIBGCC_FLOATING_MODE_SUPPORTED_P): Define. > > > > I don't see this used anywhere on trunk? Did you forget some file(s) in > > the patch? > > TARGET_LIBGCC_FLOATING_MODE_SUPPORTED_P is the name of the macro that defines > the targetm.libgcc_floating_mode_supported_p hook: Huh. And this is used nowhere in libgcc itself! > > The name isn't good (supported for _what_? It is only for complex > > multiplication, right?) > > I'm not sure what you are asking. I'm defining a standard hook. I don't have > a choice of the name to use. I thought it was new, because I didn't see it anywhere. I only looked in libgcc/ . Looks good then. Okay for trunk with the mentioned nits fixed. Thanks! Segher
