Hi!
On Thu, Apr 29, 2021 at 05:48:53PM -0400, Michael Meissner wrote:
> This patch defines the constants needed for libgcc for the PowerPC
> specific IEEE 128-bit floating point types (KFmode).
It doesn't do that though?
> The 4/28 changes to libgcc need these constants defined.
I wondered what that means... Please write "April 28", or just use the
(shortened) commit hash?
> We only define the KFmode constants if IEEE 128-bit floating point is
> supported, but long double does not use the IEEE 128-bit format. If long
> double uses the IEEE 128-bit format, it will use TFmode and not KFmode.
>
> With this patch, we don't have to modify _divkc3.c to use the FLT128
> constants. Instead, the -fbuilting-libgcc option will build the appropriate
> __LIBGCC_KF_* macros.
That sounds good.
> gcc/
> 2021-04-29 Michael Meissner <meiss...@linux.ibm.com>
>
> PR bootstrap/100327
> * config/rs6000/rs6000.c
> (TARGET_LIBGCC_FLOATING_MODE_SUPPORTED_P): Define.
I don't see this used anywhere on trunk? Did you forget some file(s) in
the patch?
Please lose the "_P", there is a verb in the name already.
The name isn't good (supported for _what_? It is only for complex
multiplication, right?)
> (rs6000_iibgcc_floating_mode_supported_p): New target hook.
Typo ("iib").
> +rs6000_libgccc_floating_mode_supported_p (scalar_float_mode mode)
Typo ("gccc").
Segher
