On Tue, Mar 9, 2021 at 10:18 AM Eric Botcazou <botca...@adacore.com> wrote: > > > The whole point of thunks is that they do not require things like copying > > ... is this case somehow IPA-SRA/CPed in an odd way? Otherwise it seems > > like the passed through reference was mishandled on the GIMPLE level? > > Maybe, but the change looks correct on its own and nobody has cared about the > issue for months, so please let's not the best be the enemy of the good...
Yes, the change looks correct - just the intent (for optimization purposes) is likely to still not have that copy ... So I'd say the patch is OK unless Honza violently objects but I think we want to investigate how we arrived at this unfortunate situation (it might be just an artifact of a strange ABI of course) Richard. > -- > Eric Botcazou > >