On Wed, Nov 18, 2020 at 03:10:21PM -0600, Pat Haugen wrote: > On 11/17/20 10:31 PM, will schmidt wrote: > >> +(define_cpu_unit "fp_div0_power10,fp_div1_power10,fp_div2_power10, > >> + fp_div3_power10" "power10div") > > > > The spacing catches my eye, I'd want to add spaces around those commas, > > etc. But.. this appears to be consistent with behavior > > as seen in the > > existing power9.md ; power9.md ; etc. > > So it's either this way per necessity, or this way per history. > > Either way, no change requested here given that precedence. > > (If this and > > the older stuff also needs to be cosmetically tweaked, that can be > > handled later on..) > > Yeah, just historical.
Yes, any whitespace is allowed before and after every entry (and you do use that for the newlines already :-) ) But it is traditional to not have spaces around the commas here. Feel free to change your habits if you want :-) > >> +(define_insn_reservation "power10-prefixed-load" 4 > >> + (and (eq_attr "type" "load") > >> + (eq_attr "update" "no") > >> + (eq_attr "size" "!128") > >> + (eq_attr "prefixed" "!no") > > > > I'm sure there is reason, but remind me.. "!no" versus "yes" ? > > >From my prior patch, the prefixed attribute can now have values > >no/yes/always, so '!no' means 'yes' || 'always'. (eq_attr "bla" "!smth") means (ne_attr "bla" "smth") (but that latter syntax is not recognised). Segher
