On 25 January 2012 20:55, Richard Henderson <r...@redhat.com> wrote:
> On 01/26/2012 02:35 AM, Greta Yorsh wrote:
>> Before the change, __sync_lock_release expanded into STRD, storing DI value
>> 0.
>
> The most important question is: Is STRD guaranteed to perform the store
> atomically? (And conversely, does LDRD perform the load atomically?)
>
ldrd and strd by themselves are not mandated to be "single-copy" atomic.
> If so (even for a subset of arch revisions going forward), then the
> correct solution is to define atomic_{load,store}di patterns.
>
> If not, then your patch is correct.
The patch is OK.
Ramana
