While trying to improve clang's handling of "#pragma GCC visibility" I
found out that libstdc++-v3/libsupc++/typeinfo looks like

#pragma GCC visibility push(default)
extern "C++" {
#pragma GCC visibility pop
}

Is that supposed to work or just happens to? If desired, the attached
patch moves the pop after the closing }.

2011-01-23  Rafael Avila de Espindola  <rafael.espind...@gmail.com>

        * libsupc++/typeinfo: Correctly match #pragma GCC visibility
        pop with #pragma GCC visibility push.

Cheers,
Rafael
diff --git a/libstdc++-v3/libsupc++/typeinfo b/libstdc++-v3/libsupc++/typeinfo
index aaa756b..39146e0 100644
--- a/libstdc++-v3/libsupc++/typeinfo
+++ b/libstdc++-v3/libsupc++/typeinfo
@@ -218,7 +218,7 @@ namespace std
   };
 } // namespace std
 
-#pragma GCC visibility pop
-
 } // extern "C++"
+
+#pragma GCC visibility pop
 #endif

Reply via email to