Olivier Hainque <hain...@adacore.com> writes:
> Ping, please ?
>
> Patch re-attached for convenience.
Looks OK to me, and I assume Richard would have spoken up by now if
he didn't think the patch did what he wanted.
> + ;; The pair of scratch registers used for stack probing with
> -fstack-check.
> + ;; Leave R9 alone as a possible choice for the static chain.
> + (PROBE_STACK_FIRST_REGNUM 10)
> + (PROBE_STACK_SECOND_REGNUM 11)
> ;; Scratch register used by stack clash protection to calculate
> ;; SVE CFA offsets during probing.
> (STACK_CLASH_SVE_CFA_REGNUM 11)
It's a bit concerning that the second register now overlaps
STACK_CLASH_SVE_CFA_REGNUM, but I agree that isn't a problem
in practice, since the two uses are currently mutually-exclusive.
I think it might be worth having a comment about that, So maybe add:
;; Note that the use of these registers is mutually exclusive with the use
;; of STACK_CLASH_SVE_CFA_REGNUM, which is for -fstack-clash-protection
;; rather than -fstack-check.
to the new comment above.
OK with that change, thanks. Sorry for the long delay in the review.
Richard
