On Wed, Jan 11, 2012 at 16:04, Tobias Burnus <bur...@net-b.de> wrote: > On 01/11/2012 02:08 PM, Janne Blomqvist wrote: >> >> Checking for an absolute path is already done a few lines up. So if >> you prefer the kind of approach that you have in your patch, IMHO a >> more correct patch would be > > > I had a quick chat with Kai and decided to leave the lower part as is. > However, I realized that the check for an absolute path is not correct for > Windows. With the help of Kai I came up with the attached version. > > > OK for the trunk?
With the minor change s/an simulator/a simulator/ in the comment, Ok. In practice, I don't think this matters at the moment, since the only place where exe_path is used is when building the argument list for addr2line in the backtrace generation. Which we don't do on Windows anyway, since windows lacks fork, exec, and pipe which we require to launch the subprocess. Making cwd "const char*" is also Ok. -- Janne Blomqvist
