> -----Original Message-----
> From: Jakub Jelinek <ja...@redhat.com>
> Sent: 10 September 2020 16:02
> To: Kyrylo Tkachov <kyrylo.tkac...@arm.com>
> Cc: Richard Earnshaw <richard.earns...@foss.arm.com>; gcc-
> patc...@gcc.gnu.org
> Subject: Re: [PATCH] arm: Fix up arm_override_options_after_change_1
>
> On Thu, Sep 10, 2020 at 02:11:25PM +0000, Kyrylo Tkachov wrote:
> > > > incorrect, rather than testing
> > > > !opts->x_str_align_functions
> > > > it should be really testing
> > > > !opts_set->x_str_align_functions
> > > > and get &global_options_set or similar passed to it as additional
> opts_set
> > > > argument. That is because otherwise the decision will be sticky, while
> > > > it
> > > > should be done whenever use provided -falign-functions but didn't
> provide
> > > > -falign-functions= (either on the command line, or through optimize
> > > > attribute or pragma).
> > >
> > > Here is a fix for that (incremental change on top of the previous patch).
> > > Bootstrapped/regtested on armv7hl-linux-gnueabi, ok for trunk?
> >
> > This looks ok to me.
> > Please commit to master so we can get some wider testing before
> backporting.
>
> Note, this patch is just an incremental patch to the previous one which
> hasn't been reviewed yet, is that one ok for master too?
> https://gcc.gnu.org/pipermail/gcc-patches/2020-September/553400.html
Yes, I had looked at that as well.
Sorry for not being explicit.
Thanks,
Kyrill
>
> > > 2020-09-10 Jakub Jelinek <ja...@redhat.com>
> > >
> > > * config/arm/arm.c (arm_override_options_after_change_1): Add
> > > opts_set
> > > argument, test opts_set->x_str_align_functions rather than
> > > opts->x_str_align_functions.
> > > (arm_override_options_after_change, arm_option_override_internal,
> > > arm_set_current_function): Adjust callers.
>
> Jakub
