Hi! On Mon, Jul 06, 2020 at 03:11:17AM +0200, Hans-Peter Nilsson wrote: > TL;DR: fixing a misdetection of what is a "simple move".
As set before, this is not a fix, not a "misdetection", it is plain and simple a behaviour change. "Use single_set for is_just_move" would be a fine subject. > Regarding a > parallel with a clobber not being "just" a move, there's only > the two adjacent callers seen in the patch (obviously with the > rename), and their use exactly matches to check that the > argument is a single_set which is a move. This isn't true, single_set has somewhat different semantics. Some of which is exactly the change you are looking for, but there are more differences. > It's always applied > to an rtx_insn, so I changed the type and name to avoid the > "just" issue. I had to adjust the type when calling single_set. Don't change the name please. Changing it to take an rtx_insn* is fine, we aren't likely to change back to testing the resulting patterns. > I checked the original commit, c4c5ad1d6d1e1e a.k.a r263067 and The history is years older (some of which is on gcc-patches@). I'll make a simpler patch. Thanks! Segher
