> From: Segher Boessenkool <seg...@kernel.crashing.org> > Date: Tue, 7 Jul 2020 01:42:47 +0200
(Regarding is_just_move in combine.c.) > But it is *not* supposed to be the same as single_set. > > > I checked the original commit, c4c5ad1d6d1e1e a.k.a r263067 and > > it seems parallels-as-sets were just overlooked and that this > > They were not. It causes regressions. That is why it has a different > name, not something with "single set". "just_move" isn't a very good > name, I couldn't come up with something better, it is a pretty > complicated concept :-/ BTW, if you feel you need to change it, *please* add a comment why single_set + general_operand is not sufficient (preferably more than "must not ignore clobbers"). It might save some time the next time someone has to go through that code. brgds, H-P
