Hi!

On Tue, Jun 16, 2020 at 02:02:36PM -0500, Peter Bergner wrote:
> On 6/15/20 5:43 PM, will schmidt wrote:
> >>    * config/rs6000/rs6000.md ('type' attribute): Add mma type.
> > 
> > (mma) : New 'type' attribute.
> 
> I just copied what someone else did, but agree this is more readable.
> Will change.

We have had before

        * config/rs6000/rs6000.md (define_attr "type"): New type popcnt.

and

        * config/rs6000/rs6000.md ('type' attribute): Add
        veclogical,veccmpfx,vecexts,vecmove insn types.

(Both are fine, double quotes is a teeny bit better).  The thing that
is changed is not named "mma", it is named "type".

"New value "mma"." or similar, maybe.  The important thing is that what
is in () is the thing that is modified, and that you mention the exact
name of the value added (spelled in full).

(Not that it matters much in this case anyway: no one will search the
changelog for "type" or even "\<type\>" or "\<type\>.*):", although,
hrm I did search for that in "git log config/rs6000", but most commits
do not have changelog entries in the commit message yet).


Segher

Reply via email to