On 5/25/20 7:42 PM, H.J. Lu wrote:
Here is the updated patch.  OK for master?

Thank you for the updated patch.

I have still few nits:

1) I would make all the:

+  has_sse3 = has_feature (FEATURE_SSE3);

a macro. The local variable seems to superfluous.

2) can we automatically deduce option name:

+  ISA_NAMES_TABLE_ENTRY("rdpid", FEATURE_RDPID, P_ZERO, "-mrdpid")
+  ISA_NAMES_TABLE_ENTRY("rdrnd", FEATURE_RDRND, P_ZERO, "-mrdrnd")

I mean "-m" + "rdrnd" == "-mrdrnd" ?

Martin

Reply via email to