On Tue, May 19, 2020 at 2:07 PM Uros Bizjak <ubiz...@gmail.com> wrote: > > On Tue, May 19, 2020 at 9:58 PM H.J. Lu <hjl.to...@gmail.com> wrote: > > > > On Mon, May 18, 2020 at 10:56 PM Uros Bizjak <ubiz...@gmail.com> wrote: > > > > > > On Tue, May 19, 2020 at 4:17 AM H.J. Lu <hjl.to...@gmail.com> wrote: > > > > > > > > On Mon, May 18, 2020 at 5:57 AM H.J. Lu <hjl.to...@gmail.com> wrote: > > > > > > > > > > On Mon, May 18, 2020 at 5:43 AM Uros Bizjak <ubiz...@gmail.com> wrote: > > > > > > > > > > > > On Mon, May 18, 2020 at 2:34 PM H.J. Lu <hjl.to...@gmail.com> wrote: > > > > > > > > > > > > > > On Mon, May 18, 2020 at 5:18 AM Uros Bizjak <ubiz...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > On Mon, May 18, 2020 at 1:58 PM H.J. Lu <hjl.to...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Add cpu model numbers for Intel Airmont, Tremont, Comet Lake, > > > > > > > > > Ice Lake > > > > > > > > > and Tiger Lake processor families. > > > > > > > > > > > > > > > > > > OK for master? > > > > > > > > > > > > > > > > OK. > > > > > > > > > > > > > > I am checking in my patch. > > > > > > > > > > > > > > > Please also update cpuinfo.c from libgcc and corresponding > > > > > > > > > > > > > > I will take a look to see if we share the same CPU detection code > > > > > > > between > > > > > > > libgcc and config/i386/driver-i386.c. > > > > > > > > > > > > I don't think it will bring any benefit, this is mainly one huge > > > > > > switch statement that maps to different stuff in libgcc and > > > > > > driver-i386. > > > > > > > > > > libgcc and config/i386/driver-i386.c differ even before my patch. > > > > > I think we can do better. > > > > > > > > > > > > > Move cpuinfo.h from libgcc to common/config/i386 so that get_intel_cpu > > > > can be shared by libgcc, GCC driver, gcc.target/i386/builtin_target.c > > > > and libgfortran to detect the specific type of Intel CPU. Update > > > > libgfortran to use has_cpu_feature to detect x86 CPU features. > > > > > > > > Tested on Linux/x86 and Linux/x86-64. OK for master? > > > > > > Handling only Intel targets and not others is a sure way for patch to > > > be ignored. > > > > > > > Here is the updated patch to cover AMD CPU. It also fixes: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95212 > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95220 > > > > OK for master? > > Huh... I didn't think the solution will be this messy... I have to > rethink the approach a bit.
That is what will happen when we have the same info in more than one place There should only one place for CPU info. > Can you in the meantime please prepare a simple patch to fix the above > mentioned PRs and eventually backport it to other release branches? It > should be simple enough to be committed under obvious rule. > Done: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546088.html -- H.J.
