On 04.05.2020 12:04, Jakub Jelinek wrote: > On Mon, May 04, 2020 at 11:49:27AM +0200, Kamil Rytarowski wrote: >>>> Please include in your patch "|| defined(__NetBSD__)". >>> >>> is this ok for you? >>> >>> This is one reason why I'd prefer #define alloca __builtin_alloca and >>> leave the include away..... >>> >>> Andreas >> >> It looks fine to me now. >> >> Personally, I would include stdlib.h unconditionally and alloca.h on >> !FreeBSD && !NetBSD. > > It just just a test. > Perhaps it could > #include <stdlib.h> > #if __has_include(<alloca.h>) > #include <alloca.h> > #endif > ? > > Jakub >
This looks fine too.
signature.asc
Description: OpenPGP digital signature
