On 03.05.2020 22:31, Andreas Tobler wrote: > On 03.05.20 18:27, Kamil Rytarowski wrote: >> On 01.05.2020 21:49, Andreas Tobler wrote: >>> Hi all, >>> >>> FreeBSD does not have the alloca.h header. Do not include it in the test >>> cases which do include alloca.h. >>> >>> There are two versions of this patch available, the one attached which >>> uses ifdef or another one which defines alloca with __builtin_alloca. >>> >>> I tested both approaches and they work on FreeBSD. I do not know which >>> one you prefer. >>> >>> Opinions welcome. >>> >>> Ok for trunk? >>> TIA, >>> Andreas >> >> Please include in your patch "|| defined(__NetBSD__)". > > is this ok for you? > > This is one reason why I'd prefer #define alloca __builtin_alloca and > leave the include away..... > > Andreas
It looks fine to me now. Personally, I would include stdlib.h unconditionally and alloca.h on !FreeBSD && !NetBSD.
signature.asc
Description: OpenPGP digital signature
