Vasee Vinayagamoorthy <vaseeharan.vinayagamoor...@arm.com> writes:
> Hi,
>
> I think this commit causes a failure on aarch64-none-elf due to a DejaGnu
> typo in gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c.
>
> { dg-final { check-function-bodies "**" "" "-O[^0]" } }
>
> I think the square brackets need to be escaped or use {-O[^0]}.Gah, this is my fault. I'd noticed that the line previously used "-DCHECK_ASM", which meant that the test would never be performed (because nothing ever adds -DCHECK_ASM for this test harness). I should have noticed that during previous review cycles and didn't want to force another review round over it, so I made the change locally. But then I compounded the mistake by messing up the testing somehow, and also forgetting about the change when doing the commit. :-( Really sorry about that, and sorry especially to Delia for messing up her patch. It sounds from off-list discussion like you have a fix in the works, so I'll defer to that. Thanks, Richard > > Regards > Vasee > > Fri, Mar 06, 2020 at 09:54:07AM +0000, Richard Sandiford wrote: >> Delia Burduv <delia.bur...@arm.com> writes: >> > Hi, >> > >> > Here is the latest version of the patch. That test should now work. >> >> Thanks, pushed. >> >> Richard
