>> - gcc_checking_assert (item->value); > I've been staring at this for quite a while, trying to figure out how > your patch can put NULL here before I realized it was just a clean-up > :-) Sending such changes independently or pointing them out in the > email/ChangeLog makes review easier.
Ok. I'll add some description on this cleanup on ChangeLog. >> @@ -5564,7 +5610,6 @@ decide_whether_version_node (struct cgraph_node *node) >> } >> clone = create_specialized_node (node, known_csts, known_contexts, >> aggvals, callers); >> - info = IPA_NODE_REF (node); > please either drop this change or change it to: > > gcc_checking_assert (info == IPA_NODE_REF (node)); > this line of code was actually necessary when adding nodes possibly > invalidated addresses of all summaries - like fast_function_summary > classes still do. So if we ever decide to use fast summaries we need a > test to remind us that info address must be obtained again. Ok. I'm not aware that, will keep the line as original. Thanks, Feng
