On Mon, 2020-01-27 at 16:23 +0100, Martin Liška wrote: > On 1/27/20 2:38 PM, David Malcolm wrote: > > Please add an > > auto_diagnostic_group d; > > here, so that -fdiagnostics-format=json can nest the note below the > > error. > > > > OK with that change. > > Sure, there's one another patch that does the for all error+inform > in the function. > > Patch can bootstrap on x86_64-linux-gnu and survives regression > tests. > > Ready to be installed? > Thanks, > Martin
LGTM, though a nit in the ChangeLog message: "couple of" to me means 2 and the number is 4, so "several" is probably better here. [1] Thanks Dave [1] though I'm probably being overly pedantic; see https://xkcd.com/1070/