Re: [PATCH] Replace one error with inform.

[David Malcolm]

On Mon, 2020-01-27 at 10:57 +0100, Martin Liška wrote:
> Hello.
> 
> The patch is about splitting pair of errors into
> error and inform which seems logical to me in this
> situation:

[...]

> diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c
> index 4520c995028..f9bed1ea4fb 100644
> --- a/gcc/cp/pt.c
> +++ b/gcc/cp/pt.c
> @@ -6149,7 +6149,7 @@ redeclare_class_template (tree type, tree parms, tree 
> cons)
>                 != TEMPLATE_PARM_PARAMETER_PACK (DECL_INITIAL (parm)))))
>       {

Please add an
          auto_diagnostic_group d;
here, so that -fdiagnostics-format=json can nest the note below the
error.

OK with that change.

Thanks
Dave

>         error ("template parameter %q+#D", tmpl_parm);
> -       error ("redeclared here as %q#D", parm);
> +       inform (input_location, "redeclared here as %q#D", parm);
>         return false;
>       }