On Fri, 18 Nov 2011, Han Shen wrote:

> Hi, Joseph, thanks!
> 
> ChangeLog entries added to the issue description.
> 
> ChangeLog
>         * Makefile.in (GPLUSPLUS_INCLUDE_DIR_ADD_SYSROOT): add a macro
>         definition to compile command.
>         * cppdefault.c (GPLUSPLUS_INCLUDE_DIR_ADD_SYSROOT): replace hard
>         coded "add_sysroot" field with the control macro.
>         * configure.ac (gcc_gxx_include_dir_add_sysroot): add a flag
>         variable to control whether sysroot should be prepended to gxx
>         include dir.
>         * configure : Regenerate.

Please make sure to follow the style of existing ChangeLog entries.  For 
Makefile.in for example it might be:

        * Makefile.in (gcc_gxx_include_dir_add_sysroot): New.
        (PREPROCESSOR_DEFINES): Define GPLUSPLUS_INCLUDE_DIR_ADD_SYSROOT.

I went to review the change as I had it queued to look at, but found that 
this message, which I had noted as the message to look at, did not 
actually contain a patch - and I cannot find any posting of the 
configure.ac changes in any of your messages to gcc-patches since at least 
the start of November.  So it's still not ready to review.  Please post a 
complete, self-contained patch submission, that includes all of:

* the patch itself, including configure.ac changes;
* the ChangeLog entries;
* self-contained rationale;
* URLs to previous gcc-patches discussion

in the one gcc-patches message.  If you have in fact already posted such a 
submission and I've failed to locate it, could you give the gcc-patches 
URL?

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to