On Tue, 15 Nov 2011, Han Shen wrote: > 2011-11-15 Han Shen <shen...@google.com> > > * gcc/Makefile.in: > * gcc/configure: > * gcc/cppdefault.c:
You need to include the full ChangeLog entries with your patch. Note that paths in ChangeLogs are relative to the directory with the ChangeLog, so no gcc/ in this case. Please also include the full rationale with your patch *and URLs for the previous discussion* (from June, it seems) so that reviewers don't need to track that down themselves. > diff --git a/gcc/configure b/gcc/configure > index 99334ce..364d8c2 100755 > --- a/gcc/configure > +++ b/gcc/configure It's not possible to review this patch as is because you've only included the changes to the generated file configure, not to its source file configure.ac. Please make sure that your resubmission includes all the source file changes. (There is no need to include the changes to the generated file configure at all in the submission; the ChangeLog entry can just mention it as "* configure: Regenerate.".) -- Joseph S. Myers jos...@codesourcery.com
